Skip to content

fix: shield:user create does not assign a default group #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: shield:user create does not assign a default group #1162

merged 1 commit into from
Aug 20, 2024

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 12, 2024 •
edited
Loading

Description
Supersedes #999
Fixes #998

The user registration form sets the default group value for the user when a new user is registered.
But the command shield:user create does not set the default group.
I think we should fix the inconsistency as a bug.

What do you think about reading the available roles from the config file and presenting that as a required choice to the user? #999 (comment)

It would be nice, but nobody has implemented it. It can be implemented as enhancement later.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Something isn't working label Aug 12, 2024
@kenjis kenjis mentioned this pull request Aug 12, 2024
Closed
datamweb
datamweb approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lonnieezell say: instead of being forced into the default and then having to go to the database to change it.

In any case, I do not see any problem in the implementation.

@kenjis
Copy link
Member Author

kenjis commented Aug 12, 2024

Oh, I have not read the comment carefully. Thanks.

And @bgeneto suggested -g option instead of showing groups and the user interaction. #999 (comment)

@datamweb
Copy link
Collaborator

suggested -g option

I like this because of less user interactions.

@kenjis kenjis mentioned this pull request Aug 12, 2024
Merged
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Aug 12, 2024

I sent a PR to implement -g option: #1164

@kenjis kenjis merged commit 2554481 into codeigniter4:develop Aug 20, 2024
@kenjis kenjis deleted the fix-command-user-create-default-group branch August 20, 2024 04:03
@kenjis kenjis mentioned this pull request Aug 21, 2024
Closed
5 tasks
@michalsn michalsn mentioned this pull request Jul 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: spark cli does not assign a default group to newly created user

2 participants

@kenjis @datamweb